Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update some packages to avoid --legacy-peer-deps #76

Merged
merged 7 commits into from
Oct 5, 2023

Conversation

EnzoVezzaro
Copy link
Contributor

@EnzoVezzaro EnzoVezzaro commented Oct 4, 2023

Changes proposed in this PR:

  • making some changes for dep updates

@vercel
Copy link

vercel bot commented Oct 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dbs-ui-lib ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 5, 2023 8:35am

@EnzoVezzaro
Copy link
Contributor Author

EnzoVezzaro commented Oct 4, 2023

Updated dependencies and some tools.

All commands work without errors:

  • npm i without --legacy-peer-deps
  • npm run build creates a dist folder with newest build
  • npm run storybook runs storybook
  • npm run build-storybook creates a static version of storybook

nevertheless when importing the build folder manually into the demo project, it doesn't seem to work properly (probably related to the new updates). This needs further investigation.

I also see that the vercel deployment is failing for some reason while in local builds correctly:

Screenshot 2023-10-04 at 1 40 31 PM

@jamiehewitt15 can you confirm that all the commands work for you too please.

@mihaisc can you please update the vercel app for these changes. The only change should be removing the --legacy-peer-deps flag from npm i and make sure all the packages are updated based on the latest package.json. Locally it builds correctly, so I'm not really sure why is failing on vercel (preview).

@mihaisc
Copy link

mihaisc commented Oct 4, 2023

Fixed, we should prioritise this so we unlock the other prs

@EnzoVezzaro EnzoVezzaro marked this pull request as ready for review October 4, 2023 13:41
@EnzoVezzaro
Copy link
Contributor Author

EnzoVezzaro commented Oct 4, 2023

@jamiehewitt15 please for testing delete your local node_modules and start this PR from scratch before testing the commands.

Copy link
Member

@jamiehewitt15 jamiehewitt15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works great. Also pulled the changes into my other branch and it works there too, fixing the vercel preview deployment

@EnzoVezzaro EnzoVezzaro merged commit 592a439 into main Oct 5, 2023
8 checks passed
@EnzoVezzaro EnzoVezzaro deleted the fix/issue-63-fix-deps-issues branch October 5, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix dependency issues
3 participants